search

PyWorkflowApp / visual-programming

A Python Visual Programming Workspace for Data Science
MIT License
33 stars 12 forks source link

Allow upload of custom node files; display node docs/errors in tooltips #72

Closed reddigari closed 4 years ago

reddigari commented 4 years ago

Matt was right about being able to reuse the FileUpload functionality, but the details were just different enough that it was easier to copy/paste/change into a new component than refactor well. So CustomNodeUpload is mostly duplicated code from FileUpload.

Upon successful upload, the app hits the endpoint for the list of available nodes to show the new one. This GIF shows the functionality, but it failed to capture the file dialog. So the random click in the middle of the screen is actually selecting the file.

2020-04-25 17 31 24

Also in this PR are tooltips to show either the node docstring when hovering over a node menu item, or the missing packages error. I went with @reelmatt's suggestion in #71 and used a warning icon for these failed custom nodes.

2020-04-25 19 03 02

Also made some slight style changes to the node menu items to better match the wireframes, just let me know if we want to go back.

reddigari commented 4 years ago

Pushed a commit that pretties up the tooltips (left-aligned, newlines displayed)