search

PyWorkflowApp / visual-programming

A Python Visual Programming Workspace for Data Science
MIT License
33 stars 12 forks source link

Adds jest unit tests #77

Closed cesaragv closed 4 years ago

cesaragv commented 4 years ago

This PR sets up and adds the initial unit tests for the front-end. As more files are touched during the run npm test, code coverage decreases

Screen Shot 2020-04-28 at 11 16 50 PM
reddigari commented 4 years ago

Looks great! I've never used snapshots to test against...how likely is it that they will need to be changed as we keep developing? I have a feeling they will be very useful vs manually writing assertions since we're strapped for time.

cesaragv commented 4 years ago

Looks great! I've never used snapshots to test against...how likely is it that they will need to be changed as we keep developing? I have a feeling they will be very useful vs manually writing assertions since we're strapped for time.

@reddigari I used them before, and once the project is stable, they don't really need to change much.

reddigari commented 4 years ago

Reminder to add the execution of these tests to the Github Actions config once #75 is merged.

reddigari commented 4 years ago

Oh I didn't catch that --- yeah it's good practice to leave them in because it ensures everyone's using the same versions and prevents dependency hell when people clone and install. @cesaragv could we put it back and see if we have the version issues you mentioned?

cesaragv commented 4 years ago

Oh I didn't catch that --- yeah it's good practice to leave them in because it ensures everyone's using the same versions and prevents dependency hell when people clone and install. @cesaragv could we put it back and see if we have the version issues you mentioned?

@reddigari yes, I just did