Fix: Update column width calculation - Githubissues

PyWorkflowApp / visual-programming

A Python Visual Programming Workspace for Data Science

MIT License

33 stars 12 forks source link

Fix: Update column width calculation #86

Closed reelmatt closed 4 years ago

reelmatt commented 4 years ago

Old method: compared row.length to previous largest row size, and replace if larger.

New method: accounts for non-string rows by calling row.toString() for non-null rows. Now, if a cell has non-string contents, it won't compare undefined, but the actual length.

Other fixes:

bumps the extra padding from 10 -> 12. Even with the new calculations, "North Highlands" rows were still getting weirdly displayed (probably a variable-width font issue).
moves TableCreator node into the io category.

reddigari commented 4 years ago

Works great on the NFL data with all its missing values as well!