search

PyaeSoneAungRgn / github-zed-theme

GitHub's Zed themes
28 stars 4 forks source link

Use different colors for keywords and types? #5

Open failable opened 4 months ago

failable commented 4 months ago

image

Compared to

image

Although the original theme did not seem to use color for types, the current version of this theme uses the same color (red) for keywords and types, making the entire window appear quite red at times...

PyaeSoneAungRgn commented 4 months ago

Thanks you, i will try to fix. Btw if you know how to fix, feel free to submit a PR.

verhovsky commented 1 month ago

GitHub's theme is defined here (I think)

https://github.com/primer/github-syntax-theme-generator/blob/main/lib/themes/light.json

https://github.com/primer/github-syntax-theme-generator/blob/main/lib/themes/dark.json

I'm surprised you can't do an exact conversion of this JSON to Zed's JSON since both GitHub and Zed use tree-sitter for parsing most languages, but from my brief look it seems like they might have different names for syntax nodes.