PyaeSoneAungRgn / github-zed-theme

GitHub's Zed themes
53 stars 12 forks source link

Highlight type nodes the same as variable nodes #9

Closed verhovsky closed 2 months ago

verhovsky commented 2 months ago

This is how GitHub does it, for example:

static int findarg(const void *a, const void *b)
{
  const struct LongShort *aa = a;
  const struct LongShort *bb = b;
  return strcmp(aa->lname, bb->lname);
}

LongShort is the type and aa is the variable name, both have the same color.

In Zed, before

Screenshot 2024-09-04 at 14 10 03

after

Screenshot 2024-09-04 at 14 09 42

The * and -> are still wrong though.

PyaeSoneAungRgn commented 2 months ago

d73a49ff is correct color for PHP. I think currently zed theme does not support multi language syntax. Please let me know if there any way to do it.

verhovsky commented 2 months ago

It is right for PHP as well, if "right" means looking like the website. The VS Code GitHub theme extension looks quite different from the website. The website:

<?php

declare(strict_types=1);

class Calculator
{
    private int $a;
    private int $b;
}

Zed with my changes:

Screenshot 2024-09-05 at 21 58 34

VS Code

Screenshot 2024-09-05 at 21 58 54
PyaeSoneAungRgn commented 2 months ago

Your changes match with Github website

Here is the new release https://github.com/PyaeSoneAungRgn/github-zed-theme/releases/tag/v0.0.4

Thanks you