search

Pychnight / TshockRpgToolKit

Master Controller for distrubtion of quests, custom npcs, custom items and skills, housing, leveling, npcshops, etc.
GNU General Public License v2.0
11 stars 1 forks source link

[Boo TS] Security issue users able to execute /boo without permissions #27

Closed Pychnight closed 2 years ago

Pychnight commented 5 years ago

The /Boo command needs to be behind permissions also when people execute it /boo it seems to error out with this error in console


Parameter name: index
  at System.ThrowHelper.ThrowArgumentOutOfRangeException (System.ExceptionArgument argument, System.ExceptionResource resource) [0x00011] in <8f2c484307284b51944a1a13a14c0266>:0 
  at System.ThrowHelper.ThrowArgumentOutOfRangeException () [0x00000] in <8f2c484307284b51944a1a13a14c0266>:0 
  at System.Collections.Generic.List`1[T].get_Item (System.Int32 index) [0x0000c] in <8f2c484307284b51944a1a13a14c0266>:0 
  at BooTS.BooScriptingPlugin.CommandLoad (TShockAPI.CommandArgs args) [0x00057] in <88c376c64dc54f3695d5e8b2d6ee9903>:0 
  at TShockAPI.Command.Run (System.String msg, System.Boolean silent, TShockAPI.TSPlayer ply, System.Collections.Generic.List`1[T] parms) [0x0001c] in <ee5ce75026b74995a03fdbd3cc824395>:0 ```
tbarela commented 5 years ago

This already requires permissions ( "boots.control" ). Check your groups.

web: www.timbarela.com email: tbarela@timbarela.com

---- On Tue, 23 Oct 2018 01:09:32 -0700 notifications@github.com wrote ----

The /Boo command needs to be behind permissions also when people execute it /boo it seems to error out with this error in console

Parameter name: index at System.ThrowHelper.ThrowArgumentOutOfRangeException (System.ExceptionArgument argument, System.ExceptionResource resource) [0x00011] in <8f2c484307284b51944a1a13a14c0266>:0 at System.ThrowHelper.ThrowArgumentOutOfRangeException () [0x00000] in <8f2c484307284b51944a1a13a14c0266>:0 at System.Collections.Generic.List1[T].get_Item (System.Int32 index) [0x0000c] in <8f2c484307284b51944a1a13a14c0266>:0 at BooTS.BooScriptingPlugin.CommandLoad (TShockAPI.CommandArgs args) [0x00057] in <88c376c64dc54f3695d5e8b2d6ee9903>:0 at TShockAPI.Command.Run (System.String msg, System.Boolean silent, TShockAPI.TSPlayer ply, System.Collections.Generic.List1[T] parms) [0x0001c] in :0 ``` — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.