Project Clean up [Week 1]

[Pychnight]

After thinking about this, I still think project clean up needs to happen but maybe it's better for it to be the first week of development.

• [x] Clean up all plugins (Improve code and layout)
  • [x] Improve Error Logging #17
• [x] #26 Missing Tab / Feature (gui tool)
• [x] Remove duplicate functions / Merge functions when needed.
• [x] Ensure All functionality is exposed properly to Boo TS Plugin.

[tbarela]

"Ensure All functionality is exposed properly to Boo TS Plugin."

I recall touching on this when I last worked on it-- but in short, this needs to be explicitly detailed. I need an itemized list of what functionality is not exposed, or what you expect to be there.

[Pychnight]

quite a lot of custom quests functionality does not work within boo ts.

Itemized list

• Being able to detect and set players regions
• Spawn monsters & custom monsters
• Spawn Items & custom items
• Detect inventory
• Detect player count
• Biome detection
• Item Use Detection

That's just a general functionality list

[tbarela]

I was looking at the boo imports again. Most of Corruptions API should be exposed already in BooTS. I did update the default imports, so you can use PlayerInventoryManager class and the Schematic module.

If there are parts that are not imported automatically, you should be able to manually import the modules yourself via boo's import statement assuming the assembly is referenced.

Getting at stuff intrinsic to CustomNpcs and CustomQuests won't work as is, as it creates a circular dependency/chicken and egg problem. BooTS can't reference those plugins.

Nor are they something you can just rip out and move. In example, the various Quest Triggers like CatchNpcs and ChestUnlock are deeply entwined with the quest plugin internals.

Its likely possible to move out BooTS's script execution into its own plugin, and make sure it calls into all other plugins... but thats going out of scope for a cleanup job. ( There will be more involved than just moving code, there always is. )

[Pychnight]

as for " * Ensure All functionality is exposed properly to Boo TS Plugin." i will specify this as the most requested function for that is the easy access function such as the "delay" function from custom quests, that function should be moved over to corruption as a general purpose function.

after that's done you can tick off that.

I will move the updated documentation to week 2 as apart of the custom skills development

[tbarela]

I've put Delay functions in Corruption, that match the ones used by Quests. But the quest specific versions still need to remain, since they use the QuestCancellationToken by default.

I also saw that the Place1xBlah methods were easy to move to Corruption, so I did.