search

PyconUK / 2015.pyconuk.org

Source for PyCon UK website
http://www.pyconuk.org/
MIT License
12 stars 38 forks source link

Add Education Day on Friday. #166

Closed zeth closed 9 years ago

inglesp commented 9 years ago

Looks good, but it's really hard to review this because all the column widths have changed -- could we avoid this in future?

Using the tool in #163 (any chance that could be merged?) has helped.

zeth commented 9 years ago

"Looks good, but it's really hard to review this because all the column widths have changed -- could we avoid this in future?"

Not really, that is kinda the whole point. Cannot dumb down the whole thing just for a bad diff implementation.

inglesp commented 9 years ago

OK -- sorta take your point. GH usually highlights the parts of lines that have changed, like this:

image

It hadn't done so here, so I'd assumed that more had changed than actually had.

Let me know if you've got any better suggestions for reviewing this kind of diff.

zeth commented 9 years ago

Build the site then local in one window, live one in one window, then apply mark one eyeball!

There was an idea next year to go AI and have George's talk review app end with a schedule, that might reduce some of the pain.

On 12 September 2015 at 13:07, Peter Inglesby notifications@github.com wrote:

OK -- sorta take your point. GH usually highlights the parts of lines that have changed, like this:

[image: image] https://cloud.githubusercontent.com/assets/28734/9831414/c5eb0c90-594e-11e5-9b21-aaf24249e973.png

It hadn't done so here, so I'd assumed that more had changed than actually had.

Let me know if you've got any better suggestions for reviewing this kind of diff.

— Reply to this email directly or view it on GitHub https://github.com/PyconUK/pyconuk.org/pull/166#issuecomment-139752070.