PyconUK / pyconuk.github.io

OLD REPOS - DO NOT USE. PyCon UK website
http://www.pyconuk.org/
3 stars 9 forks source link

Use `html-proofer` for link etc. testing #10

Closed doismellburning closed 9 years ago

doismellburning commented 9 years ago

(and fix uncovered issues)

inglesp commented 9 years ago

This'll be a great help in making sure we don't break the site!

@doismellburning, can you clarify the behaviour here? Now that we're using travis, is it the case that every PR will get tested? If so, could you update the README to say something along the lines that PRs shouldn't get merged until they're green?

doismellburning commented 9 years ago

@hawkz Please delete branches after merging, thanks!

@inglesp Yep, you nailed it - I hope that a nice big red error message + symbol on the PR would dissuade people from merging it, but sure, clarifying it can't hurt!

doismellburning commented 9 years ago

Sorry, forgot to actually enable Travis, and in combo with #11 hit a bundler/Travis interaction issue, but #14 fixes this