Closed ghickman closed 9 years ago
Could someone check this locally please? I'm not sure if the name, evil_hoover
, is a locally generated name for my docker container or not.
/tmp/pyconuk.github.io run-tests-locally
❯ make tests
Checking the conference name
Proofing the HTML
Post http:///var/run/docker.sock/v1.17/containers/evil_hoover/start: dial unix /var/run/docker.sock: no such file or directory. Are you trying to connect to a TLS-enabled daemon without TLS?
FATA[0000] Error: failed to start one or more containers
make: *** [tests] Error 1
... That error may be related to my setup actually, I can't run the website at all. I've not used docker for a while on this machine.
Thanks for working on this @ghickman.
This doesn't actually work for me either:
$ make tests
Checking the conference name
Proofing the HTML
Error response from daemon: No such container: evil_hoover
FATA[0000] Error: failed to start one or more containers
make: *** [tests] Error 1
I think that the problem is that you're trying to start a container based on a randomly-assigned name, "evil_hoover". I don't know enough about docker to know what the right thing to do here is.
Also, name-lint.sh
isn't executable at the moment, which means that you can't run it from the command line without chmod
ding it.
Closing, since this is now working at https://github.com/PyconUK/pyconuk.org.
What's this PR do?
Introduce the
make tests
command for running the tests locally. Both tests (name linting and html proofing) now live in thetests
directory.I've also fixed a bug in the name linting test to do with single brackets conditional and added the phony stuff to the makefile to avoid issues with the tests directory and tests target.
How should this be manually tested?
Checkout this branch and run
make tests
.What are the relevant tickets?
Fixes #34
Screenshots