fix: enum option issues - Githubissues

Pycord-Development / pycord

Pycord is a modern, easy to use, feature-rich, and async ready API wrapper for Discord written in Python

https://docs.pycord.dev

MIT License

2.71k stars 459 forks source link

fix: enum option issues #2463

Closed NeloBlivion closed 2 months ago

NeloBlivion commented 3 months ago

Summary

Makes two changes for better enum support in options:

If an enum's docstring is greater than 100 characters, truncate it (fixes issues on Python 3.11)
If an enum has more than 25 values, use basic_autocomplete instead of choices and forces the type back to string.

Related thread: https://discord.com/channels/881207955029110855/1238137800440942684/1238624044396314714

Information

[x] This PR fixes an issue.
[ ] This PR adds something new (e.g. new method or parameters).
[ ] This PR is a breaking change (e.g. methods or parameters removed/renamed).
[ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

[x] I have searched the open pull requests for duplicates.
[x] If code changes were made then they have been tested.
- [ ] I have updated the documentation to reflect the changes.
[ ] If type: ignore comments were used, a comment is also left explaining why.
[x] I have updated the changelog to include these changes.

JustaSqu1d commented 3 months ago

It would be nice if this behavior was documented somewhere

Lulalaby commented 3 months ago

What squid said

Dorukyum commented 2 months ago

@NeloBlivion see suggestions