Vanity URL cannot be edited anymore

Pycord-Development / pycord

Pycord is a modern, easy to use, feature-rich, and async ready API wrapper for Discord written in Python

https://docs.pycord.dev

MIT License

2.71k stars 459 forks source link

Vanity URL cannot be edited anymore #2477

Closed Lumabots closed 1 month ago

Lumabots commented 2 months ago

Summary

Guild edit has attribute vanity_role while he cant edit that

Reproduction Steps

https://github.com/Pycord-Development/pycord/blob/9ab4bd6094e067e0c7956b316f483c6730ff50d1/discord/guild.py#L1718

Minimal Reproducible Code

No response

Expected Results

N/A

Actual Results

N/A

Intents

N/A

System Information

N/A

Checklist

[X] I have searched the open issues for duplicates.
[X] I have shown the entire traceback, if possible.
[X] I have removed my token from display, if visible.

Additional Context

No response

Dorukyum commented 2 months ago

This is handled through a different endpoint.

https://github.com/Pycord-Development/pycord/blob/9ab4bd6094e067e0c7956b316f483c6730ff50d1/discord/guild.py#L1762-L1763

https://github.com/Pycord-Development/pycord/blob/ec3cf1652e574d4b59b52bde897a21ef51f221ce/discord/http.py#L1631-L1639

NeloBlivion commented 2 months ago

I think they meant it shouldn't be available because bots cannot use the endpoint (not documented, and searching on DDevs shows this is intentional) I recall reading up on this recently but it completely slipped my mind

Lulalaby commented 1 month ago

that is correct. bots can't change it anymore do to it being a big attack vector afaik for stealing and gatekeeping vanities.

Dorukyum commented 1 month ago

Then we can remove the other method.

Lulalaby commented 1 month ago

yes