Added mergeCells parsing

PydPiper / pylightxl

A light weight, zero dependency, minimal functionality excel read/writer python library

https://pylightxl.readthedocs.io

MIT License

303 stars 47 forks source link

Added mergeCells parsing #34

Closed DanChianucci closed 3 years ago

DanChianucci commented 3 years ago

I added parsing for the mergedCells attribute.

I havn't added any tests or anything due to lack of time, , but I figured I would share it anyways in the hope that it can be at least a starting point for a fully fledged feature.

PydPiper commented 3 years ago

Hey Dan! Thanks for submitting this and the testing too. We’ll review this today and get back to you.

PydPiper commented 3 years ago

Hey Dan, your addition looks sound, however this feature needs to be built out a bit more before we can merge it into the master. Currently the piece that your wrote up only reads merged cells. We will need to add the following before we can proceed:

[DONE] read merged cell workbook created by excel
[TODO] read merged cell workbook created by python tool (openpyxl, xlrd) that may write the xml a bit different
[TODO] add merge cell feature to database
[TODO] add unmerge cell feature to database
[TODO] add write merged cell to xml writers
[TODO] testing for all of these features

i've added the feature to the workflow and merged it into the dev branch where this can evolve

vviers commented 2 years ago

Hi there !

Any update on whether this feature will be added in a future release ? My team and I would be very interested in being able to use it. I can contribute if you let me know what is missing.

cc @yohanboniface

PydPiper commented 2 years ago

Hi @vviers unfortunately due to my current university obligations i have only been able to keep up with bugs for pylightxl and have not had time to address new features. I do welcome contributions if you and others are up for it! I outlined the tasks that would need to get done for a mergecell to be integrated into pylightxl above