(feature request) please consider adding type defintions

PydPiper / pylightxl

A light weight, zero dependency, minimal functionality excel read/writer python library

https://pylightxl.readthedocs.io

MIT License

300 stars 47 forks source link

(feature request) please consider adding type defintions #69

Closed ZeeD closed 1 year ago

ZeeD commented 2 years ago

Pylightxl Version: 1.59 Python Version: 3.9

Summary of Bug/Feature: at the moment pylightxl doesn't use types, nor it expose them. So tools like mypy cannot check the user interactions

Traceback:

Suggestion for fix:add typing annotations to the module

PydPiper commented 2 years ago

@ZeeD Thank you for considering using pylightxl for your project. This should be an easy add, we'll just have to make sure it is py2 backwards compatible looks like here is what we will need to follow

tpc1095 commented 1 year ago

Thank you for doing this work. I am using Pylance (seems to be the default for Visual Studio Code) and it highlights a small number of possibly serious type issues. I am looking forward to using the new version.

PydPiper commented 1 year ago

added in v1.61