search

PygmySlowLoris / vue-fab

Vue Floating Action Button
MIT License
273 stars 51 forks source link

Added toggleable rotation, updated documentation #26

Closed jvb93 closed 5 years ago

jvb93 commented 5 years ago

As discussed in #17 and #25, here's a means for devs to selectively enable/disable rotation.

Here's how it works: If there are no actions, rotation is disabled by default. IMO, the rotation signifies the menu opening, and if there is no menu to open, it shouldn't rotate.

Using the enableRotation prop, the developer may choose to enable or disable the fab rotation, provided there are actions to show.

The prop defaults to true so it's optional and a drop-in replacement for existing users.

I've also updated the docs and demo to reflect this update.

Closes #25

Edujugon commented 5 years ago

Hi @jvb93 ,

Thanks for your PR. I was thinking about providing an extra functionality to this feature, adding the complete rotation when there are no actions. I've also created a PR #27 . Check it out and tell me your thoughts.

I haven't updated the readme file nor the demo since your commits are what that exactly needs. So if you like my PR, just push those commits to that PR.

Edujugon commented 5 years ago

Thanks @jvb93 for your contribution!