Pyhass / Hive-Custom-Component

A custom version of the home assistant hive component
MIT License
33 stars 17 forks source link

[BUG] Hive Custom Component and App 2FA #136

Open hawkeye100 opened 1 year ago

hawkeye100 commented 1 year ago

Although 2FA from the app is mentioned elsewhere in various issues, it is not mentioned in the Readme for installation.

Can it be confirmed that 2FA is now a requirement for this component please, or if there may be a way round it.

I am guessing that after logging in during integration set-up there should be another dialogue asking for the 2FA code - is that right?

If so, this dialogue does not appear - so should it anyway even if the app 2FA is not working?

(I have tried switching 2FA on and off in the app, removed all trusted devices, logged off/on and removed the compnent and restarted HA - all in various combinations and sequences, all to no avail)

System is: Home Assistant 2022.11.2 Supervisor 2022.11.2 Operating System 9.3 Frontend 20221108.0 - latest

App is 10.52.2 (apparently the latest, at least from pov of Google Play)

Logs show: 2022-11-25 10:48:48.196 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration hive which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant 2022-11-25 22:55:23.058 ERROR (MainThread) [homeassistant.config_entries] Error setting up entry xxxxxxxxxx@gmail.com for hive File "/config/custom_components/hive/__init__.py", line 89, in async_setup_entry File "/usr/local/lib/python3.10/site-packages/apyhiveapi/session.py", line 503, in startSession File "/usr/local/lib/python3.10/site-packages/apyhiveapi/session.py", line 426, in getDevices await self.hiveRefreshTokens() File "/usr/local/lib/python3.10/site-packages/apyhiveapi/session.py", line 304, in hiveRefreshTokens File "/usr/local/lib/python3.10/site-packages/apyhiveapi/api/hive_auth_async.py", line 548, in refresh_token

(I have also tried to raise a case with Hive re 2FA not appearing to work in the app, but if there might be a [future] workaround from this component it might reduce the amount of frustration getting Hive to sort the app)

TIA

hawkeye100 commented 1 year ago

Apparently older version of the Hive App perform 2FA OK (though presumably lack things introduced in later versions) Installing an older version 10.50.3 on another device allowed 2FA to work, and in turn it then worked on installing the integration. (your phone needs to be verified first to receive the 2FA text messages)

The expected behaviour I was asking about is indeed a separate second dialogue asking for the 2FA code. The integration shows in the Hive App as a trusted device named 'Hive' - so hopefully whilst there will not need another code.

Obviously the Hive App needs sorting out (who knows when that will be), though in the meantime it might be helpful to mention 2FA in the installation notes for the Hive integration (along with expected behaviour) as a possible obstacle depending on the version of the app being used (and a workaround as described).

Not fully explored the integration yet, but it looks very promising for linking to our Solar management - thank you to devs and others for the integration.

rjenx commented 1 year ago

I spoke to someone at Hive, the app is expected to be fixed in version 10.55.1 current version is 10.54.1 no indication of when this will be released. My 2FA is turned off but the app thinks its still configured, changing it in the app does not change it at the server. So unless you have another phone on which you can run an older version of the app its a waiting game for Hive to sort their app.