Pylons / deform

A Python HTML form library.
Other
417 stars 161 forks source link

Validation on a sequence of mapping marks all fields as invalid #167

Open silviot opened 11 years ago

silviot commented 11 years ago

From http://deformdemo.xo7.de/sequence_of_mappings_with_initial_item/: the error class in a div.control-group causes all inputs in that control group to be marked as red. What we rellay want is mark the group itself. Can probably be solved with css changes.

schermata

silviot commented 11 years ago

On further analysis the colors seem to be correct in deform but wrong in deform_bootstrap. So deform css seems right.

Still, the focus lands on the first field of the invalid group; it should land on the first invalid field.

stevepiercy commented 4 years ago

For Deform 2.0.x the fix would require overriding styles in bootstrap.min.css in form.css.

.has-error .form-control {
  border-color: #ccc;
}
.has-error > .form-control {
  border-color: #a94442;
}
.has-error .form-control:focus {
    border-color: #66afe9;
    outline: 0;
    -webkit-box-shadow: inset 0 1px 1px rgba(0,0,0,.075), 0 0 8px rgba(102,175,233,.6);
    box-shadow: inset 0 1px 1px rgba(0,0,0,.075), 0 0 8px rgba(102,175,233,.6);
}
.has-error > .form-control:focus {
  border-color: #843534;
  -webkit-box-shadow: inset 0 1px 1px rgba(0, 0, 0, .075), 0 0 6px #ce8483;
  box-shadow: inset 0 1px 1px rgba(0, 0, 0, .075), 0 0 6px #ce8483;
}

.has-error .control-label {
  color: #333;
}
.has-error > .control-label {
  color: #a94442;
}

For Deform 3.0.x the styles are applied on each element, instead of a wrapping <div>, which makes it easier to apply styles.

trollfot commented 11 months ago

This is no longer the case, with bs5 markings. I'm not sure this qualifies for a backport.