Pylons / deform

A Python HTML form library.

Other

417 stars 161 forks source link

Add placeholder support for Text Area widget. #344

Closed suzil closed 6 years ago

suzil commented 7 years ago

refs #343

suzil commented 7 years ago

No more error now!

karantan commented 7 years ago

This can probably be merged now right?

tisdall commented 7 years ago

345 might make more sense to support other attributes. However, that PR doesn't have tests, signed contributors, docs, etc.

karantan commented 7 years ago

However, that PR doesn't have tests, signed contributors, docs, etc.

True. I'll ping suzil to fix this.

tisdall commented 7 years ago

True. I'll ping suzil to fix this.

The PR without the tests, etc is #345 . This one has all that but only supports placeholder on the textarea widget. I'm suggesting #345 would be a better PR to use, but it's lacking the components necessary for a merge.