File choosing button not translated

Pylons / deform

A Python HTML form library.

Other

416 stars 160 forks source link

File choosing button not translated #384

Open dwt opened 5 years ago

dwt commented 5 years ago

Looking at https://github.com/Pylons/deform/blob/010cb72d6b84e5b22321da831d5036b36d49eae0/deform/static/scripts/file_upload.js#L28 and https://github.com/Pylons/deform/blob/010cb72d6b84e5b22321da831d5036b36d49eae0/deform/static/scripts/file_upload.js#L29 it seems those values are not translatable.

Which is sad. Can you do anything about it?

stevepiercy commented 5 years ago

It looks like there is a way to do it. Here's a valid link that is referenced in file_upload.js. It appears that we should not use any strings in the JavaScript and put them in Deform's Chameleon template. I would support a PR and any changes needed to tests.

stevepiercy commented 5 years ago

Bootstrap 4 has two implementations of translations.

stevepiercy commented 3 years ago

Just a note, the implementations for each version of Deform and Bootstrap have subtle differences. I would accept one PR for either version, along with functional tests. A deformdemo example would not be necessary.