search

Pylons / deform

A Python HTML form library.
Other
417 stars 161 forks source link

Added a new "dev" member to extras_require #416

Closed jhaiduce closed 4 years ago

jhaiduce commented 4 years ago

This PR adds a new "dev" member to extras_require which combines the lint, testing, docs, and functional dependencies, plus tox. This allows a developer to install all the python modules required for testing, linting, and generating documentation with the command

pip install -e ".[dev]"
jhaiduce commented 4 years ago

Failures on this PR appear to be the result of Travis using Chameleon 3.8.0. Tests on my local machine passed with Chameleon 3.7.2 and failed after upgrading to 3.8.0. Probably related to issue https://github.com/Pylons/deform/issues/417.

stevepiercy commented 4 years ago

@jhaiduce yup, test failures are due to a new issue. Pinning requirements to < 3.8.0 is the immediate workaround. We need to figure out a fix going forward.

stevepiercy commented 4 years ago

We got a fix coming in, pending passing builds in #418, thanks to slav0nic in IRC.

jhaiduce commented 4 years ago

Rebased this PR against master again, hopefully all tests will pass now.

digitalresistor commented 4 years ago

You should only have to install tox to be able to run all tests, so far in all of the Pylons projects we have not added any extra's to install tox. Installing tox into the same environment where you have also installed deform can lead to all kinds of funny testing scenarios do to the way that PYTHONPATH is passed through to the underlying processes and you may end up not testing the appropriate code.

I am a huge -1 on this change, but will leave it up to the current maintainers for the project.

stevepiercy commented 4 years ago

Thanks, @bertjwregeer. I agree with not installing tox this way. I pushed another commit to remove it, and pluralized functional_testing_extras. Once it passes build, I can merge it.

Thank you @jhaiduce! This is a really good idea. I will also update the open PR #415 for contributing.md to reflect this change.