search

Pylons / deform

A Python HTML form library.
Other
416 stars 160 forks source link

Change help text/description style #451

Open stevepiercy opened 3 years ago

stevepiercy commented 3 years ago

Change the help text/description from:

<p class="help-block" >Enter some text</p>

to default:

<small id="${oid}HelpBlock" class="form-text text-muted">

and for invalid:

<small id="${oid}HelpBlock" class="form-text text-danger">
trollfot commented 7 months ago

the notation "${oid}HelpBlock" in camel-case seems a bit of out what is currently done with the rest. Maybe "help-${oid}" ?

stevepiercy commented 7 months ago

BS5 also uses div.class with form-text for help.

The id is camel case in BS5, but I much prefer snake case, as you suggest. I think I would prefer ${oid}-help, as it is better to first name the thing, then describe it. Do you have good reason to do the reverse, such as description-name?

trollfot commented 7 months ago

current, in the mapping_item template, we have "req-${oid}" and "item-${oid}". I thought it would be aligned with this kind of notation

stevepiercy commented 7 months ago

OK, that makes sense. Let's stick with the existing pattern of req-${oid}. Thank you!