search

Pylons / deform

A Python HTML form library.
Other
417 stars 161 forks source link

Convert choices that are a generator to a list #469

Closed stevepiercy closed 4 years ago

stevepiercy commented 4 years ago
digitalresistor commented 4 years ago

This is great! It would have at least given me an early warning!

karantan commented 1 year ago

IMO, a minor version should be changed because of this (and not a patch) change because it breaks the app if you don't convert all the map/generators to e.g. lists.

If the version would change from 2.0.14 -> 2.1.0 (and not 2.0.15) we would know that something changed in the lib that changes the behavior, but because it was a patch update I had to spend ~2h digging deeper and deeper until I found this