tdamsma
commented
3 years ago Judging by the size of the instructions, setting up Selenium is the most difficult/problematic part of contributing. To address this, it would be nice at least support running Selenium in a container. This can be achieved with the following setup code:
def setUpModule():
global browser
from selenium.webdriver import DesiredCapabilities, Remote
browser = Remote(
command_executor="http://localhost:4444/wd/hub",
desired_capabilities=DesiredCapabilities.FIREFOX,
)
browser.set_window_size(1920, 1080)
return browserTo use, one can install/start selenium and browser with a single command:
docker run -d -p 4444:4444 -p 5900:5900 -v /dev/shm:/dev/shm selenium/standalone-firefox:4.0.0-alpha-7-prerelease-20200826 To visually inspect progress a VNC server is running inside the selenium container
Perhaps a test setup can be made that allow switching between running Selenium locally and in a container.
As the tests also require deformdemo to be running (which is already containerized) , it would make even more sense to be able to run the entire test suite with a docker-compose file.
That dockerfile could look something like this:
version: "3.2"
services:
deformdemo:
hostname: deformdemo
build:
context: deformdemo
selenium:
hostname: selenium
image: selenium/standalone-firefox:4.0.0-alpha-7-prerelease-20200826
ports:
- 5900:5900 # for vnc debugging
environment:
- VNC_PASSWORD=secret
- SCREEN_WIDTH=1920
- SCREEN_HEIGHT=1080
volumes:
- /dev/shm:/dev/shm
tester:
container_name: tester
build:
context: .
dockerfile: Dockerfile-tests
depends_on:
- deformdemo
- seleniumrunning the entire test suite from scratch could then be as simple as (provided the prerequisites git and docker are available):
git clone deform
docker-compose up
docker exec -it tester bash -c nosetests All the setup instructions can be codified inside the two dockerfiles instead of scattered around bash scripts, instructions and yaml files. For development purposes a second dockerfile can be added that has the local sourcecode mounted inside so that it can be updated without having to rebuild the container
sydoluciani
stevepiercy
Replace run-selenium-tests.bash with Dockerfile, and run docker instead of run-selenium-tests.bash for local test, then replace lines 36 to 39 of .travis.yml to run Deformdomo docker in travis.