search

Pylons / deform

A Python HTML form library.
Other
417 stars 161 forks source link

Add selenium firefox container #473

Closed sydoluciani closed 4 years ago

sydoluciani commented 4 years ago

added docker-py dependency and passed environment variables in tox.ini that is going to be used in Deformdemo to start selenium container.

stevepiercy commented 4 years ago

Is this a draft PR?

sydoluciani commented 4 years ago

Is this a draft PR?

It is a working and functional PR, you can clone, set the environment variable and verify the docker container start, stop and test completes successfully. I might make new changes tomorrow, do you want me to create a new branch or just push it to this branch ?

stevepiercy commented 4 years ago

I'll try it out, and you can set the PR to "Draft" so that it does not get merged.

sydoluciani commented 4 years ago

@stevepiercy I made all requested changes that you made in other pull request, please check and if you can please test it locally and let me know.

sydoluciani commented 4 years ago

@stevepiercy I did update the contributing.md but needs some indentation, I will fix it tomorrow along other required changes.

sydoluciani commented 4 years ago

This is really cool. Thank you!

I still have a few more things to reorganize in contributing.md, but this all works. I can toggle between how I want to run functional3 tests by setting WEBDRIVER.

Thank you for fixing the indentation, my development server is running on AWS and can't properly check the formating before pushing to github. I'd appreciate it if you would take one last look at the diff on contributing.md, especially the one piece about setting the URL environment variable.

URL should be host name or ip address. URL value is being sent to browser to connect to server that has been started using pserve, putting 0.0.0.0 in browser wont work.

Not sure why localhost didn't work for me, even though my development server is not local to me and it is running on AWS, but it is local to selenium docker container. as longs as contributors won't puzzle with first connection failure and try the ip address or hostname instead of local host, we are good.

At some point I thought maybe localhost is the localhost within the Docker container and not the localhost set in host, so gave up in more testing. again it depends on environment and how it is set in Selenium container browser setting.

Just adding ip address or host name instead of localhost shall be enough.

stevepiercy commented 4 years ago

Thank you! Change made, I'll wait for build to pass before merging.