search

Pylons / deform

A Python HTML form library.
Other
416 stars 160 forks source link

Optional registry #486

Closed tdamsma closed 3 years ago

tdamsma commented 3 years ago

Implements changes suggested in #485.

I already put it up here for review, but did not properly document the changes yet.

stevepiercy commented 3 years ago

This is looking good! Just a couple more lines to cover. Lint and docs don't like the docstrings, so I'll suggest improvements to fix those jobs.

stevepiercy commented 3 years ago

@tdamsma the functional tests started failing after the merge commit https://github.com/Pylons/deform/pull/486/commits/51b5418c4a78b035f1b95711cf82edbb2bb50dbb. Can you take a look to see what needs fixing?

tdamsma commented 3 years ago

yes, I'll have a look. I switched computer three times in the last week, so need to take a moment to get a proper environment up and running. I can't see why/how 51b5418 could have changed anything for the functional tests though

stevepiercy commented 3 years ago

@tdamsma I approve your work. Would you please review my docstring improvements and documentation additions in the last commit? I think I got it right, but it helps to have a second pair of eyes. Thank you!

stevepiercy commented 3 years ago

I think we're done. w00t! Thank you @tdamsma!