search

Pylons / deform

A Python HTML form library.
Other
416 stars 160 forks source link

Remove spurious styles definition, leftover copy&paste artifact #505

Closed lelit closed 3 years ago

lelit commented 3 years ago

I'm not sure if this is what you meant, that is, if indeed you prompted me for two PRs...

stevepiercy commented 3 years ago

Yup, that's what I meant. Thank you!

Functional tests are failing in the builds for both PRs, so I need to look into that. It needs to be fixed before the PRs can be merged. It could be any number of things have changed since they were last run successfully, but an initial glance looks like something changed in Selenium. This job installs selenium==4.0.0b1 and the last successful job used selenium==4.0.0a7.

stevepiercy commented 3 years ago

The issue was in fact Selenium. I made some fixes and force pushed them to your PR against main. The build now passes. Thank you!