search

Pylons / deform

A Python HTML form library.
Other
416 stars 160 forks source link

Make parent formid a part of autogenerated oid #520

Open ezag opened 3 years ago

ezag commented 3 years ago

Better late then never :) https://github.com/Pylons/deform/issues/394

stevepiercy commented 3 years ago

@ezag lint is failing. Would you please run tox -e format, commit, and push?

I'll do a detailed review once GitHub Actions passes.

stevepiercy commented 3 years ago

@ezag additionally the functional tests must pass. Please let me know if you need assistance with that part. It can be tricky because deformdemo is in a separate repository.

ezag commented 3 years ago

@stevepiercy thanks, looks like there's plenty of instructions on setting up & running the functional tests - I'm going to get to it in a while

stevepiercy commented 2 years ago

Would you also please run black over the code base with tox format, commit, and push to this PR? That should resolve at least the lint build error.

ezag commented 2 years ago

@stevepiercy added meaningful test name and applied tox format; also updated related functional test https://github.com/Pylons/deformdemo/pull/120

stevepiercy commented 2 years ago

@ezag it looks like GitHub Actions deprecated pypy3 on macos-latest. Would you please rebase your branch on main to add the changes I just made to your branch and push?

ezag commented 2 years ago

@stevepiercy rebased on up-to-date main