search

Pylons / pylons

Pylons Framework, community maintained with guidance/assistance from the Pylons Project. Merged with repoze.bfg for Pyramid framework.
Other
231 stars 76 forks source link

Readthedocs pages trigger mixed content warning in Chrome #33

Open moreati opened 9 years ago

moreati commented 9 years ago

The documentation pages at https://pylons-webframework.readthedocs.org/en/latest/index.html are served over https. They include the stylesheet http://static.pylonsproject.org/fonts/neuton/stylesheet.css using an http:// url, not an https:// one.

In Chrome this means the file is not loaded, so that style is not applied. Sorry this isn't a PR, I couldn't find where in pyramids/docs/en the stylesheet is specified.

stevepiercy commented 9 years ago

This brings up several more issues.

First, where did you find the URL with https? We might need to update it.

The canonical URL is: http://docs.pylonsproject.org/projects/pylons-webframework/en/latest/

No projects under the Pylons Project are served over https from their canonical URLs. I'm not sure why that is. I vaguely remember a discussion that it was not worth the effort but it would be necessary in the future. Maybe the future is now?

If the html_theme of pylonsfw is updated, as well as its base theme pylons, I would recommend undoing the git submodule dance that this repo currently requires. There is now a separate package, https://github.com/Pylons/pylons-sphinx-themes, with instructions on how to convert a Pylons Project repo that currently uses a git submodule method to using the package. A decision to change would need to come from @bbangert.

moreati commented 9 years ago

Hmm, probably a false alarm

  1. My jumping off point was https://www.google.co.uk/#q=%22entry_points%22+plugin
  2. The top result is http://pylons-webframework.readthedocs.org/en/latest/advanced_pylons/entry_points_and_plugins.html
  3. That was turned into https because I have HTTPS Everywhere

I mistakenly thought Google had sent me to https.

stevepiercy commented 9 years ago

Thanks for the detail.

I consider this to be an issue. I think we should enable HTTPS on all of our docs and static assets used by our themes, then update the links to those external assets to use HTTPS.