search

Pylons / pyramid-cookiecutter-starter

A Cookiecutter (project template) for creating a Pyramid starter project with choices for template language (Jinja2, Chameleon, or Mako), persistent backend (none, SQLAlchemy with SQLite, or ZODB), and mapping of URLs to routes (URL dispatch or traversal)
95 stars 53 forks source link

sqlalchemy: stamp should not use `None` #134

Closed ctheune closed 6 months ago

ctheune commented 7 months ago

I stumbled over this while adding type stubs to my pyramid project: https://github.com/sqlalchemy/alembic/issues/1420#issuecomment-1938707864

So this (and a few lines later) should rather use "base" instead of None as the revision.

https://github.com/Pylons/pyramid-cookiecutter-starter/blob/0baa17979f0c683879e8b8b829e2b5d3b0a0e225/%7B%7Bcookiecutter.repo_name%7D%7D/tests/sqlalchemy_conftest.py#L35

mmerickel commented 7 months ago

Awesome, we can make that change. Thanks for the report!