search

Pylons / pyramid-cookiecutter-starter

A Cookiecutter (project template) for creating a Pyramid starter project with choices for template language (Jinja2, Chameleon, or Mako), persistent backend (none, SQLAlchemy with SQLite, or ZODB), and mapping of URLs to routes (URL dispatch or traversal)
95 stars 53 forks source link

refactor code in module #89

Closed ephraimbuddy closed 4 years ago

ephraimbuddy commented 4 years ago

This PR is just a refactor of codes I feel can be improved.

When I opened the module post_gen_project.py in my editor, it had some linting errors. This refactor fixes it.

stevepiercy commented 4 years ago

I would want linting performed by tox and Travis, if we are going to start enforcing lint. I don't want someone else to have a different definition of lint for their particular editor. Without it, I would reject this proposal.

Aside from that, its output must be compared against the output in the Pyramid docs wherever cookiecutters are used, and, if there are any changes, then the docs must also be updated on each affected branch.

@mmerickel do you have any concerns for this PR?

mmerickel commented 4 years ago

👍