search

Pylons / pyramid

Pyramid - A Python web framework
https://trypyramid.com/
Other
3.97k stars 887 forks source link

Backport to 1.10: fix imp deprecation #3659

Closed leorochael closed 3 years ago

leorochael commented 3 years ago

This is affecting the 1.10 branch today.

stevepiercy commented 3 years ago

@leorochael would you please sign CONTRIBUTORS.txt, and push that commit? Thank you!

leorochael commented 3 years ago

@leorochael would you please sign CONTRIBUTORS.txt, and push that commit? Thank you!

I was hoping not to have to do that since at first I just backported @mmerickel's commit to another branch.

But I guess I added enough new code to be able to stradle old and new Python versions, so I'll add myself.

leorochael commented 3 years ago

@stevepiercy, thank you for your review and approval.

What are the next steps for inclusion and new point release of the 1.10 branch?

stevepiercy commented 3 years ago

@mmerickel is release manager, and he should review this PR, too.

Assuming he approves, he mentioned last weekend that a Pyramid 2.0 final release would come within a week. I assume he will conduct a release party soon in which the 1.10-branch will be a celebrated honoree.

mmerickel commented 3 years ago

@leorochael LGTM - Could you please add a changelog entry for this bugfix? Thank you!

leorochael commented 3 years ago

@mmerickel, sorry I couldn't get to it this weekend.

Thanks for merging and adding the changelog!

mmerickel commented 3 years ago

No worries, I just ask out of laziness. :-) Thanks for the PR!