search

Pylons / pyramid_layout

Pyramid add-on for managing UI layouts.
Other
24 stars 26 forks source link

add test_home #22

Closed plitzenberger closed 10 years ago

plitzenberger commented 10 years ago

The Demo Package currently contains a Test which don't works. This PR provide a test for the "home" view.

chrisrossi commented 10 years ago

Can you expand on the rationale for this pull request? Thanks!

plitzenberger commented 10 years ago

Sorry for my cryptic PR. What do you think. Is it useful?

chrisrossi commented 10 years ago

I have no idea. The reason for the PR is not apparent to me.

plitzenberger commented 10 years ago

I think if there is a test, this test should work. It is confusing to start with a demo package where the tests are not passing.

plitzenberger commented 10 years ago

I had updated the description before my first answer. Sorry, I'm not sure if you have noticed.

"The Demo Package currently contains a Test which don't works. This PR provide a test for the "home" view."

chrisrossi commented 10 years ago

Ah, I didn't see that. Helps immensely. Thanks.

chrisrossi commented 10 years ago

Thanks for the PR!

On Fri, Nov 1, 2013 at 3:21 PM, plitzenberger notifications@github.comwrote:

I had updated the description before my first answer. Sorry, I'm not sure if you have noticed.

"The Demo Package currently contains a Test which don't works. This PR provide a test for the "home" view."

— Reply to this email directly or view it on GitHubhttps://github.com/Pylons/pyramid_layout/pull/22#issuecomment-27593496 .