search

Pylons / pyramid_layout

Pyramid add-on for managing UI layouts.
Other
24 stars 26 forks source link

Pyramid-layout broken with pyramid-jinja2 >= 2.0 #28

Closed dairiki closed 10 years ago

dairiki commented 10 years ago

The template renderers from pyramid-jinja2 >-= 2.0 no longer have a .template attribute. (Instead they have a callable .template_loader.)

I’m not absolutely certain that this is not a bug in pyramid-jinja2 rather than pyramid-layout. OTOH, so far as I can tell the only documented API for renderers (as of pyramid 1.5) is __call__().

dairiki commented 10 years ago

Ping! Any comments on this?

As things stand, pyramid-jinja2 is unusable with pyramid-layout. What can I do to get this PR accepted? Or should I file a ticket with pyramid-jinja2?

einSelbst commented 10 years ago

Thank you for adding this fix. pyramid_layout is now working for me with jinja2. It took my a while until I had the idea to look into the issue list. It would be awesome if the maintainer(s) would include your pr.

chrisrossi commented 10 years ago

Jeff, thanks for the fix, and sorry about the wait.

dairiki commented 10 years ago

Thanks, Chris!

dairiki commented 10 years ago

@chrisrossi What's the timescale for the next release to pypi?

chrisrossi commented 10 years ago

Not long after someone tells me they'd like a release. ;)

Chris

On Fri, Aug 15, 2014 at 5:42 PM, Jeff Dairiki notifications@github.com wrote:

@chrisrossi https://github.com/chrisrossi What's the timescale for the next release to pypi?

— Reply to this email directly or view it on GitHub https://github.com/Pylons/pyramid_layout/pull/28#issuecomment-52361084.

dairiki commented 10 years ago

Well, in that case ... ahem ... it would be useful to me if this PR made it into PYPI (so that I can run the latest releases of pyramid-layout and pyramid-jinja2 together.)

There's no huge rush, but when you get a chance: "I'd like a release".

Thanks!

On Fri, Aug 15, 2014 at 02:46:06PM -0700, Chris Rossi wrote:

Not long after someone tells me they'd like a release. ;)

Chris

On Fri, Aug 15, 2014 at 5:42 PM, Jeff Dairiki notifications@github.com wrote:

@chrisrossi https://github.com/chrisrossi What's the timescale for the next release to pypi?

chrisrossi commented 10 years ago

Done. I meant to do this two weeks ago, but squirrel....

Chris

On Fri, Aug 15, 2014 at 6:34 PM, Jeff Dairiki notifications@github.com wrote:

Well, in that case ... ahem ... it would be useful to me if this PR made it into PYPI (so that I can run the latest releases of pyramid-layout and pyramid-jinja2 together.)

There's no huge rush, but when you get a chance: "I'd like a release".

Thanks!

On Fri, Aug 15, 2014 at 02:46:06PM -0700, Chris Rossi wrote:

Not long after someone tells me they'd like a release. ;)

Chris

On Fri, Aug 15, 2014 at 5:42 PM, Jeff Dairiki notifications@github.com wrote:

@chrisrossi https://github.com/chrisrossi What's the timescale for the

next release to pypi?

— Reply to this email directly or view it on GitHub https://github.com/Pylons/pyramid_layout/pull/28#issuecomment-52367850.

dairiki commented 10 years ago

Thank you, Chris!