Closed jon-betts closed 3 years ago
I just remembered, we (me, @mmerickel, and @bertjwregeer) decided to move this repo into the Tomb, but I don't remember the reasons. I think the reason is a lack of an active maintainer who actually uses it.
Although I approved this PR, there are some issues I should mention.
coverage
environment passes.Failing coverage:
...................................
Name Stmts Miss Cover
---------------------------------------------------------
pyramid_layout/__init__.py 1 0 100%
pyramid_layout/compat.py 7 2 71%
pyramid_layout/config.py 191 6 97%
pyramid_layout/interfaces.py 5 0 100%
pyramid_layout/layout.py 47 0 100%
pyramid_layout/panel.py 18 0 100%
pyramid_layout/tests/__init__.py 0 0 100%
pyramid_layout/tests/test_config.py 423 0 100%
pyramid_layout/tests/test_layout.py 107 0 100%
pyramid_layout/tests/test_panel.py 75 0 100%
pyramid_layout/tests/test_zcml.py 2 0 100%
pyramid_layout/zcml.py 23 4 83%
---------------------------------------------------------
TOTAL 899 12 99%
----------------------------------------------------------------------
I've added a follow up PR to try and work on some of the deficiencies mentioned here:
These changes could be merged here if you'd prefer.
This also fixes testing for Python 2.7 and removes 2.6, 3.2 and 3.3 as they are end of life.
Testing notes
.python-version
file has been added for easier testing withpyenv
tox.ini
.pypirc
file to get the Python 2.7 tests to run for some reason. My guess is the format has changed in a way that isn't compatible with older versions ofsetuptools
.For: https://github.com/hypothesis/h/issues/6600