Add Github Actions CI - Githubissues

jon-betts commented 3 years ago

This also:

Fixes pypy testing
Separates running tests from running the coverage report
This means we can generate Python 2.7 and 3.9 coverage reports and merge the results
This allowed some no cover type comments to be removed
Adds a coverage file which enforces a minimum coverage level (not 100%)

This does not:

Add coverage to get higher than before
Add lint to the project
Add docs or lint to CI

Review notes

This builds on: https://github.com/Pylons/pyramid_layout/pull/36
Actions can be seen running here: https://github.com/jon-betts/pyramid_layout/actions/runs/810254815
The main style of the CI script and tox was taken from https://github.com/Pylons/deform

jon-betts commented 3 years ago

Hi, I've responded to, but not implemented all of the feedback given, as I feel some of it doesn't work. I'm also totally happy if you want to edit or modify this PR in anyway.

stevepiercy commented 3 years ago

LGTM!

Ping @bertjwregeer for final review.

digitalresistor commented 3 years ago

Thanks!

You wouldn't by chance be interested in helping maintain this project moving forward?

jon-betts commented 3 years ago

I don't think so sorry. This work was done under the umbrella of a project to upgrade our projects to Python >3.6 which is now coming to a close. Technically we got confirmation that this project supported the required version once I had the tests working locally, but I pushed to get some time to contribute the fixes back. I think the steer is that there's appetite for spending time on contributing fixes, but probably not on taking on maintenance.

digitalresistor commented 3 years ago

Alright, thanks for your contribution @jon-betts

Pylons / pyramid_layout

Add Github Actions CI #37

Review notes