Pylons / trypyramid.com

trypyramid.com marketing website
https://trypyramid.com
18 stars 33 forks source link

bootstrap-multiselect is broken with jQuery 3.5.1 #277

Closed digitalresistor closed 4 years ago

digitalresistor commented 4 years ago

This breaks the extending https://trypyramid.com/extending-pyramid.html filtering. We should find a replacement or something.

digitalresistor commented 4 years ago

@stevepiercy

I've temporarily hard-pinned jQuery to 3.4.1, which seems to work.

stevepiercy commented 4 years ago

Yeah, for now.

Here's a jsFiddle with the following requirements, and demo HTML and JS copied from https://davidstutz.de/bootstrap-multiselect/#getting-started. It seems to work.

stevepiercy commented 4 years ago

This combination seems to work locally. We'll see in a minute for the production site.

stevepiercy commented 4 years ago

Yup, we're good. Setting both dependencies and resolutions to jQuery 3.5.1 was the ticket. But I expect this will all fall apart when jQuery 4.0.0 is released.

digitalresistor commented 4 years ago

I had tried that before... no joy. Great, glad it's solved!