Pylons / waitress

Waitress - A WSGI server for Python 3
https://docs.pylonsproject.org/projects/waitress/en/latest/
Other
1.44k stars 164 forks source link

Bugfix on Windows: OSError is not subscriptable #361

Closed digitalresistor closed 2 years ago

digitalresistor commented 2 years ago

When Waitress fails to launch on Windows due to an issue with the trigger socket not being ready for connections, we attempt to loop. In the past this was done by subscripting the OSError and checking to see if it matched errno.WSAEADDRINUSE, this is no longer possible in newer verisons of Python.

This is a quick bugfix for a rare case which should no longer happen on Windows.

Related: https://github.com/Pylons/waitress/issues/354

digitalresistor commented 2 years ago

This should get merged after #358 is merged, since that PR fixes the CI issues.