search

Pylons / waitress

Waitress - A WSGI server for Python 3
https://docs.pylonsproject.org/projects/waitress/en/latest/
Other
1.45k stars 175 forks source link

Set `clear_untrusted_proxy_headers` parameter to `True` by default #370

Closed Yourun-proger closed 2 years ago

Yourun-proger commented 2 years ago

Refs to #330 I just changed the default value and removed the warning. I also removed the _bool_maker, because it was no longer needed. An update has been made in the documentation.

digitalresistor commented 2 years ago

This change is not making it into 2.1.1, if you could update it to 2.1.2 that would be great.

digitalresistor commented 2 years ago

Please run:

tox -e format

to make sure the code matches the coding style required. You will also want to run tests locally and remove/fix any tests that now fail due to the removal.

Yourun-proger commented 2 years ago

Oh! Forgive me for this major omission... Now I refactored through tox and changed version. I would like to ask: is this test, on which CI fails, really needed now? After all, this test just checked that the deprecation message appears. Now it has nothing to check. Should it be removed?

digitalresistor commented 2 years ago

Yes, it can be removed if the test is no longer relevant. Please be aware that #330 is also about cleaning up other warnings, of which there are far more than just the proxy one that you are cleaning up here. I am okay with accepting this small change, but it does not fix #330.

Yourun-proger commented 2 years ago

Now all must be OK

digitalresistor commented 2 years ago

Thank you!