search

Pymol-Scripts / Pymol-script-repo

Collected scripts for Pymol
http://www.pymolwiki.org/index.php/Git_intro
435 stars 257 forks source link

Independent color and as_putty options for color_by_conservation.py #145

Closed pslacerda closed 3 months ago

pslacerda commented 3 months ago

Now the option color and as_putty works independent of each other.

pslacerda commented 3 months ago

Put your @JarrettSJohnson and @speleo3 as reviewers because I don't know if I can accept my own PR.

speleo3 commented 3 months ago

Why did you remove the _self argument? It's key for using pymol2.PyMOL instances. See the tests for usage examples.

pslacerda commented 3 months ago

It was my fault.

This cmd reference should be changed to _self?

https://github.com/Pymol-Scripts/Pymol-script-repo/blob/1cb0eaff867c988b97d33a695290c48dea56117e/color_by_conservation.py#L30

speleo3 commented 3 months ago

This cmd reference should be changed to _self?

Yes

pslacerda commented 3 months ago

Done.