search

Pymol-Scripts / Pymol-script-repo

Collected scripts for Pymol
http://www.pymolwiki.org/index.php/Git_intro
437 stars 257 forks source link

Complete overhaul of colorblindfriendly for PyMOL 2.0. #94

Closed jaredsampson closed 6 years ago

jaredsampson commented 6 years ago

Complete overhaul for PyMOL 2.0 with conversion to module format. Now, setting the new cb_* color values requires a call to the set_colors() function after import. You can also now add a cb_colors menu to the OpenGL GUI via the add_menu() function. See updated wiki page for example. https://pymolwiki.org/index.php/Colorblindfriendly

speleo3 commented 6 years ago

great work by the way! Sorry for being so pedantic :-)

jaredsampson commented 6 years ago

Thanks :)

jaredsampson commented 6 years ago

Not completely related, but to make using this easier, I'm thinking about adding a cb_colors.py file to import this module and add the menu in one step. I wanted to make the functions available here, so they could be used in scripts, but it's a lot to ask users to type and remember to import colorblindfriendly; colorblindfriendly.add_menu() and would much rather import cb_colors. @speleo3 would you have a preference on this?

speleo3 commented 6 years ago

No preference. Sounds like a simple but effective addition. Also note that PyMOL users like to "run" scripts instead of importing them, but I think you've already covered that by checking __name__ == 'pymol'.