Pyomo / pyomo

An object-oriented algebraic modeling language in Python for structured optimization problems.
https://www.pyomo.org
Other
1.9k stars 490 forks source link

Name of subsets method is confusing #1560

Open Robbybp opened 3 years ago

Robbybp commented 3 years ago

The term "subset" is overloaded in Pyomo right now. I think "subset" should refer the mathematical notion of containment between sets, and the subsets method of Sets, which gives the sets that were used to construct a SetProduct, should be called something else.

Some options:

I think I favor projected_sets, as coordinate_sets seems to imply that each set occupies a single coordinate, or is 1-dimensional. projected_sets could be confusing as well, as you can project onto any vector (space), but I think it's good enough, and canonically_projected_sets seems like overkill. factor_sets is good too.

Robbybp commented 3 years ago

The name chosen here should probably correspond to the name of the utility function added in #1541