Pyomo / pyomo

An object-oriented algebraic modeling language in Python for structured optimization problems.
https://www.pyomo.org
Other
1.9k stars 490 forks source link

Handle uninitialized variable in `propagate_solution` of scaling transformation #3275

Open Robbybp opened 1 month ago

Robbybp commented 1 month ago

Fixes #3273

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.56%. Comparing base (6fb0c5d) to head (dc04352). Report is 97 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3275 +/- ## ========================================== + Coverage 88.51% 88.56% +0.04% ========================================== Files 865 865 Lines 97585 97586 +1 ========================================== + Hits 86381 86427 +46 + Misses 11204 11159 -45 ``` | [Flag](https://app.codecov.io/gh/Pyomo/pyomo/pull/3275/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pyomo) | Coverage Δ | | |---|---|---| | [linux](https://app.codecov.io/gh/Pyomo/pyomo/pull/3275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pyomo) | `86.49% <100.00%> (+<0.01%)` | :arrow_up: | | [osx](https://app.codecov.io/gh/Pyomo/pyomo/pull/3275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pyomo) | `75.84% <100.00%> (+<0.01%)` | :arrow_up: | | [other](https://app.codecov.io/gh/Pyomo/pyomo/pull/3275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pyomo) | `86.68% <100.00%> (+<0.01%)` | :arrow_up: | | [win](https://app.codecov.io/gh/Pyomo/pyomo/pull/3275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pyomo) | `83.97% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pyomo#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Robbybp commented 1 week ago

This should fix #2817 as well.