Closed kutlay closed 2 months ago
@jsiirola Thank you for the help! Changes are done and it should be good to go now.
@kutlay - can you please install the latest version of black
and run black -S -C
on your code? Thank you!
@mrmundt sorry for the delay, the black reformatting is done. You can kick off the workflow again.
@kutlay - FYI, the pypy job will fail, but it's not your fault.
We're waiting for Jenkins to run on this before merging.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.46%. Comparing base (
53d5cad
) to head (072c2c5
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #3127
Summary/Motivation:
Issue 3127 showed that HiGHs solution was different when the same variable was fixed and unfixed. A solution should not change after fixing and unfixing the same variable. The issue showed the hint that HiGHs solver was expecting the deleted row indices to be sorted. This fix sorts the indices before sending it to the solver.
Unfortunately, HiGHs code doesn't explain why the indices supplied to deleteRows need to be sorted: https://github.com/ERGO-Code/HiGHS/blob/13363c9f1252b015cf6527132eb9cf8f4b5bf020/src/lp_data/Highs.cpp#L2871-L2883
However, the error message indicates that they need to be sorted, so I can't think of any problems sorting the indices in pyomo other than slight degradation in performance because of sorting.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: