Open bknueven opened 2 weeks ago
Thanks for the PR, this is a good change. I have a minor concern about backward incompatibility, see below. Also, can you add a small unit test to
TestPyomoNLP
intest_nlp.py
that exercises this functionality?
Thanks for the review. I believe I have address all comments except for potential modifications to SuffixFinder
to support a context
argument. I believe the same potential issue would also affect the NL writer.
Fixes # N/A
Summary/Motivation:
Scaling factors in the
PyomoNLP
interface will not be applied if thescaling_factor
Suffix is on a sub-block.Changes proposed in this PR:
PyomoNLP
scaling determination methods to useSuffixFinder
instead (23d316e, a7791e1)PyomoGreyBoxNLP
andPyomoNLPWithGreyBoxes
to useSuffixFinder
(8215ef8, c7b1bca)scaling_factors
(0b4d16b)As-is this PR would change the behavior of these methods in that they would always return scaling factors. I cannot seem to exactly replicate the prior behavior which would allow all existing tests to pass without modification.
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: