Pyomo / pyomo

An object-oriented algebraic modeling language in Python for structured optimization problems.
https://www.pyomo.org
Other
1.99k stars 511 forks source link

Raise error in `generate_strongly_connected_components` instead of asserting #3305

Closed Robbybp closed 2 months ago

Robbybp commented 3 months ago

Fixes #3297

More useful error message.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.49%. Comparing base (f5e6f32) to head (fe79414). Report is 22 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3305 +/- ## ========================================== - Coverage 88.50% 88.49% -0.01% ========================================== Files 868 868 Lines 98427 98430 +3 ========================================== - Hits 87112 87107 -5 - Misses 11315 11323 +8 ``` | [Flag](https://app.codecov.io/gh/Pyomo/pyomo/pull/3305/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pyomo) | Coverage Δ | | |---|---|---| | [linux](https://app.codecov.io/gh/Pyomo/pyomo/pull/3305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pyomo) | `86.30% <100.00%> (+<0.01%)` | :arrow_up: | | [osx](https://app.codecov.io/gh/Pyomo/pyomo/pull/3305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pyomo) | `75.61% <100.00%> (-0.01%)` | :arrow_down: | | [other](https://app.codecov.io/gh/Pyomo/pyomo/pull/3305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pyomo) | `86.50% <100.00%> (+<0.01%)` | :arrow_up: | | [win](https://app.codecov.io/gh/Pyomo/pyomo/pull/3305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pyomo) | `83.81% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Pyomo#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.