search

Pyozer / flutter_material_color_picker

Material color picker, you can customize colors. Selection in two step, first main color and after shades.
https://pub.dartlang.org/packages/flutter_material_color_picker
MIT License
75 stars 38 forks source link

Fixing Padding #9

Closed Nexushunter closed 5 years ago

Nexushunter commented 5 years ago

Changes

Changed the padding within the shades widget.

Reason

Noticed that the colours were pushed together on a smaller display

Usage

My File Manager Project

Pyozer commented 5 years ago

Hi ! Thank you for your pull request, I will check this soon and merge it ;)

Nexushunter commented 5 years ago

No problem and keep up the good work. Love the package!

On Thu., Jul. 11, 2019, 04:38 Jean-Charles Moussé, notifications@github.com wrote:

Hi ! Thank you for your pull request, I will check this soon and merge it ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Pyozer/flutter_material_color_picker/pull/9?email_source=notifications&email_token=AHBNTIMVV5GB6HZZBV2MH7TP63WR3A5CNFSM4IAYZ7FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZV67AI#issuecomment-510390145, or mute the thread https://github.com/notifications/unsubscribe-auth/AHBNTIJM7KJFW4NSLSEMM23P63WR3ANCNFSM4IAYZ7FA .

Pyozer commented 5 years ago

After recheck this package, it seem that adding padding on shades is not good, because it's already manage by Grid and the main and shade colors have not same size anymore 😢

I add possibility to provide the space between colors, and fixed missing space value in number of colors per line calculation. You can update to 1.0.2 😉

Nexushunter commented 5 years ago

Sounds good.

On Thu., Jul. 18, 2019, 21:03 Jean-Charles Moussé, notifications@github.com wrote:

After recheck this package, it seem that adding padding on shades is not good, because it's already manage by Grid and the main and shade colors have not same size anymore 😢

I add possibility to provide the space between colors, and fixed missing space value in number of colors per line calculation. You can update to 1.0.2 😉

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Pyozer/flutter_material_color_picker/pull/9?email_source=notifications&email_token=AHBNTIMRNLSA3CKIDV5QA5DQAEHFJA5CNFSM4IAYZ7FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2KIFPQ#issuecomment-513049278, or mute the thread https://github.com/notifications/unsubscribe-auth/AHBNTIJF2VJ5JYVA6R756ALQAEHFJANCNFSM4IAYZ7FA .