PyratLabs / ansible-role-k3s

Ansible role for installing k3s as either a standalone server or HA cluster.
BSD 3-Clause "New" or "Revised" License
627 stars 135 forks source link

multiarch k3s_airgap #189

Closed tomaszduda23 closed 2 years ago

tomaszduda23 commented 2 years ago

k3s_airgap does not support multiarch. It is possible to specify only one binary for airgap installation. It should be per arch.

crutonjohn commented 2 years ago

i agree, that's probably a great feature to add. I didn't really have that in mind when i was initially developing it.

i'm unsure what the lift will look like to build the logic into the role, however.

unfortunately i'm tied to a few projects at this moment. if i get some free cycles i'll come back to work on it. if you want to try your hand at it i'd be happy to help review and get it merged.

crutonjohn commented 2 years ago

In an initial pass, it seems like the user could provide the separate binaries in ./files something like this:

./files/k3s_x86_64
./files/k3s_arm64
...

and then have some matching logic to match against ansible's built-in Magic Variables, specifically ansible_architecture.

tomaszduda23 commented 2 years ago

Probably it is best to use logic from ensure_downloads.yml. x64 do not have suffix on https://github.com/k3s-io/k3s/releases/tag/v1.23.6%2Bk3s1 so it would be more convenience if names match 1:1

./files/k3s
./files/k3s_arm64
stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.