search

PyratLabs / ansible-role-k3s

Ansible role for installing k3s as either a standalone server or HA cluster.
BSD 3-Clause "New" or "Revised" License
640 stars 135 forks source link

Refactor/remove-secret-encryption-experimental #201

Closed dbrennand closed 1 year ago

dbrennand commented 1 year ago

Remove secret-encryption as experimental

Summary

Fixes #200. The secret-encryption is no longer an experimental feature.

Issue type

Additional Information

Please let me know if there is anything else I need to change. I'm not sure whether the k3s_use_experimental variable in molecule/highavailabilityetcd/converge.yml needs removing because of this change.

dbrennand commented 1 year ago

Tests are failing due to Ansible lint failures unrelated to this PR. If you'd like I can help fix those? 🙂

dbrennand commented 1 year ago

Hey @onedr0p - Would you be able to PR this? 🙂

dbrennand commented 1 year ago

The changes here look fine, and Ansible lint is broken due to updates to Ansible itself. I would merge this however I'm not sure how to cut a release, and maybe the lint errors should be fixed too.

Thanks a lot for taking a look @onedr0p 🙂 - I started working on fixing the lint issues in #202 but I was awaiting feedback on some of the task names.