Pyrdacor / Ambermoon.net

Ambermoon rewrite in C#
GNU General Public License v3.0
422 stars 22 forks source link

Item name adjustments (german language) #160

Closed skdubg closed 3 years ago

skdubg commented 3 years ago

hi,

there are some typos inside the cheat console for the german language. i will wrote the corrected entrys here.

monsters: 044-047: GARGOYLE

items: 085: MYSTISCHER GLOBUS 139: MAGISCHE FLUGSCHEIBE 312: VALDYN'S LEDERSCHUHE (its 20 chars long, could be too much, the max i see are 19) 358: SANSRIE'S HALSBAND

Also, the monster "Gargyle" is misspelled, it needs to be spelled "Gargoyle". I suspect this is misspelled throughout the game, can this be possible? I guess the same for 'Mystischer Globe'.

skdubg commented 3 years ago

i agree with you 😁 then you must change "ss" to "ß" where is it possible/right

skdubg commented 3 years ago

here we need the "ß"

Unbenannt20

skdubg commented 3 years ago

two times "ß"

Unbenannt21

skdubg commented 3 years ago

fixed in excel list!

i never played "Amberstar", does it have anything to do with the story?

@a1exh otherwise it could be a bug? we are in Spannenberg. (same on english data)

Unbenannt22

skdubg commented 3 years ago

another "ß" needed

Unbenannt23

Unbenannt24

Unbenannt25

Unbenannt26

Unbenannt27

Unbenannt28

skdubg commented 3 years ago

we need a "c"

Unbenannt29

skdubg commented 3 years ago

a "g" is missing

Unbenannt30

a1exh commented 3 years ago

i never played "Amberstar", does it have anything to do with the story?

TWIN LAKE was a place in Amberstar which is destroyed (partially?) by the meteor in Ambermoon.

I can't read German or know the context but there are lots of references to Amberstar in Ambermoon

skdubg commented 3 years ago

TWIN LAKE was a place in Amberstar which is destroyed (partially?) by the meteor in Ambermoon.

I can't read German or know the context but there are lots of references to Amberstar in Ambermoon

thank you. the connection among the games is a little familiar to me. what I want to say: it's the sign next to the puzzle mouth in Gauner's cellar in Spannenberg I do not understand why it is written here that it is the Thieves Guild of Twinlake

skdubg commented 3 years ago

fixed in excel list!

Unbenannt31

here is written "Stadt Burnville", remember: "Die Stadt Spannenberg" wich was one char too much (exceed the map title boundaries)

skdubg commented 3 years ago

fixed in excel list!

four times "ß" at Luminor

Unbenannt32

Unbenannt33

Unbenannt34

Unbenannt35

skdubg commented 3 years ago

fixed in Excel list!

Valdyn... remove the "e" and another two times"ß" needed

Unbenannt36

Unbenannt37

skdubg commented 3 years ago

fixed in excel list!

many "ß" in the game

Unbenannt38

Unbenannt39

Unbenannt40

skdubg commented 3 years ago

fixed in excel list!

next batch of "ß"

Unbenannt41

Unbenannt42

one times "herzlich" should be enough :)

Unbenannt43

Unbenannt44

Unbenannt45

Unbenannt46

Unbenannt47

skdubg commented 3 years ago

three times "ß" needed and an "ä"

Unbenannt48

Unbenannt49

Unbenannt50

nicodex commented 3 years ago

I really like the German ß. I grew up with it and found it irritating that it was replaced in so many places with the "Neue deutsche Rechtschreibung". Hated that thing.

Thalion seems to have took some effort to make the ß available. I want to cherish and keep it. Call me old-fashioned but the game is old and I don't want to take it's old charm from it.

It's like an old book. You wouldn't correct the older language as long as it isn't obviously wrong in the context of that time. ;)

I agree with this - even if the new ß rules are much simpler now :)

Same thing with the apostrophe - you cannot get it right without adding code/logic to the game. This would require checks for words ending with a s/z-like sound - even the player's name - for all "[name]~'s" in the game and engine text. To make it even more complicated, the game concatenates some text. Therefore, personally I would leave it as is - back in the days the Genitiv-Apostroph was usual.

skdubg commented 3 years ago

Same thing with the apostrophe - you cannot get it right without adding code/logic to the game. This would require checks for words ending with a s/z-like sound - even the player's name - for all "[name]~'s" in the game and engine text. To make it even more complicated, the game concatenates some text. Therefore, personally I would leave it as is - back in the days the Genitiv-Apostroph was usual.

I am also in favor of the apostrophe I mentioned above, because it also represents the name better. Unfortunately, it has not been implemented consistently in the game.

It will take a very long time to check all the texts. Especially since I do it ingame and don't take the files apart.

I think it is now the unique chance to complete the game. The remake is incredible.

nicodex commented 3 years ago

It will take a very long time to check all the texts. Especially since I do it ingame and don't take the files apart.

A year ago I dumped some text bocks of v1.05 and v1.07 for preservation purposes: https://gitlab.com/ambermoon/research/-/wikis/text/blocks (and references). Might be useful as a quick overview, to resolve string numbers, or compare the German/English text.

Pyrdacor commented 3 years ago

It will take a very long time to check all the texts. Especially since I do it ingame and don't take the files apart.

A year ago I dumped some text bocks of v1.05 and v1.07 for preservation purposes: https://gitlab.com/ambermoon/research/-/wikis/text/blocks (and references). Might be useful as a quick overview, to resolve string numbers, or compare the German/English text.

To be honest I used it quiet often. Many of your provided resources were very useful. This is the reason why you got a special place in the credits as well. ;)

skdubg commented 3 years ago

all with a "ß" and an apostroph for Shandra's please

Unbenannt51

Unbenannt52

Unbenannt53

Unbenannt54

Unbenannt55

Unbenannt56

Unbenannt57

Unbenannt58

Unbenannt59

Unbenannt60

Unbenannt61

Unbenannt62

skdubg commented 3 years ago

Hello all,

after seeing the sources from @nicodex , I have chosen a different strategy to find the spelling errors in German. Since otherwise it would probably take months.

It is wonderful to copy into Excel and so easier to read and sift. I go through text by text.

I understand that it is only spelling errors, missing apostrophes (where they have already been placed elsewhere) and the "ss" / "ß" problem.

Everything else remains the same. Inserting them into the game files would still need to be done, of course. I hope you agree with this.

Many greetings

Pyrdacor commented 3 years ago

hi,

there are some typos inside the cheat console for the german language. i will wrote the corrected entrys here.

monsters: 044-047: GARGOYLE

items: 085: MYSTISCHER GLOBUS 139: MAGISCHE FLUGSCHEIBE 312: VALDYN'S LEDERSCHUHE (its 20 chars long, could be too much, the max i see are 19) 358: SANSRIE'S HALSBAND

Also, the monster "Gargyle" is misspelled, it needs to be spelled "Gargoyle". I suspect this is misspelled throughout the game, can this be possible? I guess the same for 'Mystischer Globe'.

I started fixing them in the original german data. I found that "ALCHEMIST. GLOBE" was also wrong. But as Gargyle was used so much (even in map texts) I did a bit more research. And indeed Gargyle exists. At least in DSA. So I guess this is on purpose and I won't change it.

Pyrdacor commented 3 years ago

I will mark those I fixed locally on my end with a "rocket symbol" here.

Pyrdacor commented 3 years ago

TWIN LAKE was a place in Amberstar which is destroyed (partially?) by the meteor in Ambermoon. I can't read German or know the context but there are lots of references to Amberstar in Ambermoon

thank you. the connection among the games is a little familiar to me. what I want to say: it's the sign next to the puzzle mouth in Gauner's cellar in Spannenberg I do not understand why it is written here that it is the Thieves Guild of Twinlake

Because the thief guild originated in Twinlake. I guess this is correct.

Pyrdacor commented 3 years ago

Valdyn... remove the "e" and another two times"ß" needed

Unbenannt36

Unbenannt37

I don't know if we should fix all "ss" to "ß". The rules back then were much different than today. For example "dass" was written as "daß" back then. So in the given screenshot for Valdyn we also would have to fix the "dass". But I am not sure if it's worth the effort.

Pyrdacor commented 3 years ago

Maybe skip the "ss" and "ß" stuff and focus on typos for now.

Pyrdacor commented 3 years ago

I fixed the "PLÖTZLICHE" and "HERZLICH HERZLICH". Now only ß should be open. But as I said I don't want to fix them.

skdubg commented 3 years ago

I change it only where it is obviously wrong (Grüße, Große, ...) just "Grüße" occurs in both variants

have seen other real mistakes and texts that I have never seen before.

skdubg commented 3 years ago

hello, i need help with this sentence:

NACH UNGEFÄHR ZEHN JAHREN TRAT EINE ENTWICKLUNG EIN, ÜBER DIE SICH DIE MEISTEN DER ZWERGE, DENEN IHR ZUHÖRT, NUR ZÖGERLICH ÄUßERN, ABER SCHLIEßLICH BEKOMMT IHR DIE SOVIEL MIT, DASS SICH ZU DIESER ZEIT STIMMEN ERHOBEN, DIE NICHT MEHR IN DEN CHOR DES JAMMMERNS UND KLAGENS ÜBER DAS LEBEN AUF DEM \"KOMPOSTHAUFEN\" EINSTIMMEN WOLLTEN.

I think the word I marked here in bold is too much. is that right?

Pyrdacor commented 3 years ago

Yes. I already fixed it.

skdubg commented 3 years ago

i need help again.

what is the right name: PELANI or PELANIS ?

a1exh commented 3 years ago

what is the right name: PELANI or PELANIS ?

We went through this in a different thread. The original English version contained a mix. If you added them all up there was more references (in English) to PELANIS than PELANI so we changed them all to PELANIS

skdubg commented 3 years ago

We went through this in a different thread. The original English version contained a mix. If you added them all up there was more references (in English) to PELANIS than PELANI so we changed them all to PELANIS

Thank you. I found the same in german. There is only one text with "PELANI" so i will change it to "PELANIS"

skdubg commented 3 years ago

hello all,

I have corrected the map_texts from the data of @nicodex now

of 1324 entries, 379 were corrected. I hope it can be easily traced back to the game data

I'll continue with the NPC_texts tonight

a1exh commented 3 years ago

@skdubg Don't you think it would be easier to modify the existing patched game data using @Pyrdacor's tools? Then it wouldn't have to be merged back. They are not hard to use. Just a few CLI tools for Linux/windows which unpack & split the .amb files into numerous sub-files. You edit them carefully and then use the tools to join-repack back into the reuseable files.

skdubg commented 3 years ago

@a1exh you might be right, i haven't dealt with that. i think i should do that and take a look. thanks

a1exh commented 3 years ago

The last release was a while ago (June) but I imagine they are good to use? @Pyrdacor?

https://github.com/Pyrdacor/Ambermoon/releases/tag/v1.0.6

a1exh commented 3 years ago

You need the latest patched Amberfiles directory from here :

https://github.com/Pyrdacor/Ambermoon/tree/master/Disks/Bugfixing/German

Copy the tool AmbermoonTextImport.exe to the same directory as Amberfiles. Make a temp directory called Texts

./AmbermoonTextImport.exe -e Amberfiles 1Map_texts.amb Texts

This will unpack, split and pre-process the files into sub-files and text-blocks e.g. Texts/1Map_texts.amb/059/000.txt

Carefully edit the files.

Then run the tool again :

./AmbermoonTextImport.exe -i Amberfiles 1Map_texts.amb Texts

This should re-insert the files back into 1Map_texts.amb ready for use.

a1exh commented 3 years ago

I know nothing about special german character codes. I don't know if a standard text editor like notepad++ can insert the correct characters for re-insertion. Ask @Pyrdacor

skdubg commented 3 years ago

Thank you, I think I have understood the structure and principle. Now I have to transfer the already corrected parts into the single txt files.

EDIT: self-test of the game is working

Pyrdacor commented 3 years ago

Sorry saw this too late. Yes the tools are good to go. I use them myself too. @a1exh explained the usage nicely.

I had no problems with german Umlauts etc. I used Visual Studio Code but Notepad++ should work too. Just don't mess up the file encoding. :D I think the tools use UTF-8 which most editors also use. But you can just test the changes yourself in the original game and/or remake.

I also make updates from time to time so make sure you use the most recent versions from here: https://github.com/Pyrdacor/Ambermoon/tree/master/Disks/Bugfixing/German

And tell me when there is new stuff I should add. You can also do so via Pull Request but it's also ok to attach the file here to an answer of yours and I'll add it.

Pyrdacor commented 3 years ago

I recommend using Visual Studio Code. It's free and you can perform text searches easily over directories. So you can search and replace texts of all files at once.

skdubg commented 3 years ago

hello all,

I have worked through and corrected the current NPC_texts.amb, Object_texts.amb and Party_texts.amb, but i need help with one sentence here is spoken in the masculine form: (Object_texts.amb\005\000.txt)

"...EIN GEWISSER ~SELF~ SOLL DIE GRUPPE LEITEN. SOLL ER DOCH KOMMEN! SELBST WENN ER AM WACHDÄMON VORBEIKOMMEN SOLLTE, WAS IHM NICHT GELINGEN KANN, DANN BEKÄME ER ES IMMER NOCH MIT MIR ZU TUN."

greetings

Pyrdacor commented 3 years ago

"...EIN GEWISSER MENSCH NAMENS \~SELF\~ SOLL DIE GRUPPE LEITEN. SOLL \~SEX1\~ DOCH KOMMEN! SELBST WENN \~SEX1\~ AM WACHDÄMON VORBEIKOMMEN SOLLTE, WAS NICHT GELINGEN KANN, DANN BEKÄME \~SEX1\~ ES IMMER NOCH MIT MIR ZU TUN."

skdubg commented 3 years ago

perfect, thank you.

Pyrdacor commented 3 years ago

I plan the new releases for tomorrow afternoon or Friday. So if you can make it until then that would be great.

Pyrdacor commented 3 years ago

Did you test your changes with WinUAE etc?

skdubg commented 3 years ago

It will be tight. I can't promise to have it ready by Friday. At least I could put in a night shift Friday to Saturday.

tried it with the remake, got to some places with the teleporter. I don't have WinUAE set it up :(

Pyrdacor commented 3 years ago

For texts the remake should be fine for testing.

skdubg commented 3 years ago

I made it faster than I thought after all. All six files have been reviewed text by text and corrected/adjusted. Hopefully not too much was overlooked. A test with the remake worked.

The last changes by @Pyrdacor from the 3Map_texts.amb from today are also included.

Ambermoon_texts.zip

@Pyrdacor you can close the Issue if you received the files.