[Bug report] Savegames temporarly gone after patching

[Pyrdacor]

In general Windows users just start the app with normal privileges (not admin). In this case the app has often no write permissions inside the app folder. In this case the app checks for that and fallbacks to some user application data folder for savegames, screenshots and the configuration file.

However when patching the application explicitly asks for admin rights because it needs to copy files. But then the app itself is also started with admin rights and then might be able to write to the app folder directly.

The problem now is that the saves are inside the user application data folder while the current app instance expects them in the app folder (as it now has write access and can't know that it is only temporary).

It could be fixed by starting the app with normal privileges after patching but this is only half the solution. The user can decide to start the app with admin rights at any time and won't see pre-existing saves then as well.

It might be better to do the following:

• Check both folders for existing configs, savegames and screenshots.
• If they exist in only one of them, load them from there.
• Regarding saving:
  • If the saves and config exist in the user app data folder, always save changes there even with app folder write access
  • If the saves and config exist in the app folder:
  • If you have write access to that folder, store them there
  • Otherwise copy them over to the user application data folder (only when saving changes) and save changes there afterwards

There might be a remaining problem. If the last saving case happens and afterwards the user starts with admin rights, the first saving case will prevent from saving inside the app folder forever. However there might be old saves and configs and the user might wonder why they are not updated.

[Pyrdacor]

Needs testing but maybe the patcher now starts the exe with normal privileges after patching.